Re: [Qemu-devel] [PATCH v1 1/1] char: cadence_uart: Convert to realize()

[Alexander Graf]

On 03.07.14 18:59, Andreas Färber wrote:
> Am 03.07.2014 18:46, schrieb Peter Maydell:
> > On 24 June 2014 07:06, Alistair Francis <address@hidden> wrote:
> > > SysBusDevice::init is deprecated. Convert to Object::init and
> Note that there is no Object::init, only TypeInfo::instance_init.
>
> > > Device::realize as prescribed by QOM conventions.
> > >
> > > Signed-off-by: Alistair Francis <address@hidden>
> > > ---
> > >
> > >   hw/char/cadence_uart.c |   29 ++++++++++++++++-------------
> > >   1 files changed, 16 insertions(+), 13 deletions(-)
> > >
> > > diff --git a/hw/char/cadence_uart.c b/hw/char/cadence_uart.c
> > > index bf0c853..5a22a72 100644
> > > --- a/hw/char/cadence_uart.c
> > > +++ b/hw/char/cadence_uart.c
> > > @@ -468,27 +468,30 @@ static void cadence_uart_reset(DeviceState *dev)
> > >       uart_update_status(s);
> > >   }
> > >
> > > -static int cadence_uart_init(SysBusDevice *dev)
> > > +static void candence_uart_realize(DeviceState *dev, Error **errp)
> > Typo in your new function name :-)
> >
> > Otherwise
> > Reviewed-by: Peter Maydell <address@hidden>
> LGTM, but I wonder whether the work Alex is doing on SysBusDevice
> requires us to introduce SysBusDevice::realize, called from
> Device::realize in SysBusDevice code?

I don't think we need a realize function with my patch set - all work 
happens either during the creation phase (generate hint properties) or 
in the machine, after realize has successfully passed.


Alex