[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow l
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change |
Date: |
Wed, 2 Jul 2014 15:53:12 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 02.07.2014 um 00:09 hat Eric Blake geschrieben:
> On 07/01/2014 02:48 AM, Stefan Hajnoczi wrote:
> > From: Jeff Cody <address@hidden>
> >
> > This allows a user to make a live change to the backing file recorded in
> > an open image.
> >
>
> > +
> > + /* final sanity check */
> > + if (!bdrv_chain_contains(bs, image_bs)) {
> > + error_setg(errp, "'%s' and image file are not in the same chain",
> > + device);
> > + return;
> > + }
>
> Phooey - this is not bisectable, because bdrv_chain_contains was only
> introduced in 22/24. But it's already been pulled, so nothing we can do
> about it now.
We should probably start using git-compile-check before doing pull
requests. At least I haven't been doing this so far.
Kevin
pgpza9ZcXjwH6.pgp
Description: PGP signature
- Re: [Qemu-devel] [PULL for-2.1 13/24] qemu-img create: add 'nocow' option, (continued)
- [Qemu-devel] [PULL for-2.1 14/24] iotests: Simplify qemu-iotests-quick.sh, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 15/24] iotests: Add qemu tests to quick group, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 17/24] block: make 'top' argument to block-commit optional, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 16/24] iotests: Add more tests to quick group, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 18/24] block: simplify bdrv_find_base() and bdrv_find_overlay(), Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 19/24] block/cow: Avoid use of uninitialized cow_bs in error path, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 20/24] qapi: Change back sector-count to sectors-count in quorum QAPI events., Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 21/24] block: add QAPI command to allow live backing file change, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 23/24] block: extend block-commit to accept a string for the backing file, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 22/24] block: add helper function to determine if a BDS is in a chain, Stefan Hajnoczi, 2014/07/01
- [Qemu-devel] [PULL for-2.1 24/24] block: add backing-file option to block-stream, Stefan Hajnoczi, 2014/07/01
- Re: [Qemu-devel] [PULL for-2.1 00/24] Block patches, Peter Maydell, 2014/07/01