[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 3/3] configure: Fix -lm test, so that tools can b
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PULL 3/3] configure: Fix -lm test, so that tools can be compiled on hosts that require -lm |
|
Date: |
Wed, 2 Jul 2014 10:40:54 +0100 |
On 2 July 2014 08:02, Markus Armbruster <address@hidden> wrote:
>> This looks to me like we're leaving ourselves open for
>> a smarter compiler with linktime optimisation to complain
>> that x is used uninitialized.
>
> x *is* initialized, to zero. A sufficiently smart compiler(TM) could
> figure out that x is still zero in main(), and constant fold the test
> away.
Yes, I was wrong there.
> Suggest to use argc.
That's what we did -- see commit f80ea986.
thanks
-- PMM