Re: [Qemu-devel] [PATCH]Fix a error in mc146818rtc.c

[Stefan Hajnoczi]

On Tue, Jul 01, 2014 at 03:53:08AM +0800, Lb peace wrote:
> If you use hwclock in guest os ,you will find the result of hwclock isn't
> changed after changing host os's clock.
> I find this issue is generated in this patch:
> 
> http://lists.gnu.org/archive/html/qemu-devel/2013-08/msg03353.html
> Before this patch,the result will be changed if you change host's clock.
> It makes use of the following codes in qemu-timer.c:
>         if (now < last) {
>             notifier_list_notify(&clock->reset_notifiers, &now);
>         }
> It is useless if you register a QEMU_CLOCK_REALTIME's clock_reset_notifier,
> ---

Missing Signed-off-by: Your Name <address@hidden>

All patches in QEMU must have a Signed-off-by.  For more details on the
meaning of S-o-b, see:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/SubmittingPatches;h=689e2371095cc5dfea9927120009341f369159aa;hb=f6f94e2ab1b33f0082ac22d71f66385a60d8157f#l297

>  hw/timer/mc146818rtc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/timer/mc146818rtc.c b/hw/timer/mc146818rtc.c
> index df54546..821c27e 100644
> --- a/hw/timer/mc146818rtc.c
> +++ b/hw/timer/mc146818rtc.c
> @@ -879,7 +879,7 @@ static void rtc_realizefn(DeviceState *dev, Error
> **errp)

Please use git-send-email(1) to send patches.  Or make sure there is no
line-wrapping or other mangling of the patch.

git-am(1) cannot apply your patch because of the line-wrapping.

You can find the guidelines for submitting patches to QEMU here:
http://qemu-project.org/Contribute/SubmitAPatch

pgpQsIomfsvd1.pgp
Description: PGP signature