Re: [Qemu-devel] [PATCH] qemu-char: Convert socket char backend to parse/kind

[Paolo Bonzini]

Il 30/06/2014 14:33, Peter Maydell ha scritto:
> > >
> > > It's unnecessary.  tcp_chr_accept calls tcp_chr_add_client, which takes care
> > > of that.  But it doesn't hurt either.
> I think the tcp_chr_accept->tcp_chr_add_client->set_nonblock
> is marking the new fd returned from accept() as nonblocking.
> The call in qemu_chr_open_socket_fd() is marking the listening
> fd as nonblocking. So those are different things...

Uh, you're right.  I think the call in qemu_chr_open_socket_fd simply 
means "after the currently connected disconnects, subsequent accepts 
will be done via select(), so the socket can now be marked as 
non-blocking".  The qemu-char logic is right then.

Paolo