Re: [Qemu-devel] [PATCH v5 1/4] block: Support Archipelago as a QEMU block backend

[Eric Blake]

On 06/23/2014 06:32 AM, Chrysostomos Nanakos wrote:
> VM Image on Archipelago volume is specified like this:
> 
> file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>][:
> segment=<segment_name>]]
> 
> or
> 
> file.driver=archipelago,file.volume=<volumename>[,file.mport=<mapperd_port>[,
> file.vport=<vlmcd_port>][,file.segment=<segment_name>]]
> 

I still plan to review this series in full, but my quick pre-review comment:

on version 2, Markus suggested that you should separate the patch that
adds QMP structured options (first) from the patch that adds syntactic
sugar
file=archipelago:<volumename>[/mport=<mapperd_port>[:vport=<vlmcd_port>]] 
(second)

https://lists.gnu.org/archive/html/qemu-devel/2014-06/msg00269.html

and I stand by his suggestion, although I don't see that split here yet.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature