Re: [Qemu-devel] [PATCH for-2.1 v2 2/2] char: report frontend open/closed state in 'query-chardev'

[Eric Blake]

On 06/26/2014 05:11 AM, Laszlo Ersek wrote:
> In addition to the on-line reporting added in the previous patch, allow
> libvirt to query frontend state independently of events.
> 
> Libvirt's path to identify the guest agent channel it cares about differs
> between the event added in the previous patch and the QMP response field
> added here. The event identifies the frontend device, by "id". The
> 'query-chardev' QMP command identifies the backend device (again by "id").
> The association is under libvirt's control.
> 
> RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1080376
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
> 

>  ##
> -{ 'type': 'ChardevInfo', 'data': {'label': 'str', 'filename': 'str'} }
> +{ 'type': 'ChardevInfo', 'data': {'label': 'str',
> +                                  'filename': 'str',
> +                                  'frontend-open': 'bool'} }

Hmm; I wonder if this should instead be
'frontend-status':'VirtioSerialPortStatus', to reuse the type from patch
1/2.  That way, if we ever add a third state, then both the event and
the poll will be reusing the same enum values to report that state.


-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature