Re: [Qemu-devel] memory: memory_region_transaction_commit() slow

[Etienne Martineau]

On 14-06-25 02:58 PM, Paolo Bonzini wrote:
> Il 25/06/2014 19:53, Etienne Martineau ha scritto:
>>
>> It seems to me that there is a scale issue O(n) in 
>> memory_region_transaction_commit().
>>
>> Basically the time it takes to rebuild the memory view during device 
>> assignment
>> pci_bridge_update_mappings() increase linearly with respect to the number of
>> device already assigned to the guest.
> 
> That's correct, unfortunately.  It can be fixed, it's not hard but also not 
> trivial.
> 
> Basically you can detect address spaces whose memory region is an alias of an 
> address space's root memory region.  You can then reuse that address space's 
> FlatView instead of building another one.

Thanks for your reply.

I'm not too sure to understand what you mean by 'reuse that address space's 
flatview'?

Are you suggesting to push update directly in the flatview? If so then any 
further 
update to that address space will wipe out the flatview changes previously done 
isn't.

thanks,
Etienne