qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/4] Introduce common QEMU_COMPAT_* macros


From: Michael S. Tsirkin
Subject: Re: [Qemu-devel] [PATCH 0/4] Introduce common QEMU_COMPAT_* macros
Date: Wed, 25 Jun 2014 10:34:24 +0300

On Tue, Jun 24, 2014 at 03:02:00PM -0300, Eduardo Habkost wrote:
> This series is an attempt to make the compat_props lists from the PC code
> reusable by other machine-types. All the compat bits that are on those lists 
> are
> not tied to a specific machine-type, but instead to the device code that was
> present on a given QEMU version.
> 
> The last patch is a proposal to simply eliminate the PC-specific compat props
> macros, because we don't really need them today. All compat properties we have
> can be on global QEMU-version-specific lists, because PC-specific properties 
> are
> not going to affect other machine-types anyway.

So global properties are really not so special.
They just need to be specified with <X>.<Y>=<Z> syntax.
Can we just make them properties of a QEMU object?

I would like to make it possible for management to
ask "what's the default value for that property with that
machine type".

Need to add API to make this painless, with not more lines of code
than currently.

> Eduardo Habkost (4):
>   q35: Move q35-specific compat macros to pc_q35.c
>   pc: Eliminate nesting of common PC_COMPAT_* macros
>   machine: Introduce QEMU_COMPAT_* macros
>   [RFC] Eliminate PC-specific compat_props
> 
>  hw/i386/pc_piix.c    |  31 +++++--
>  hw/i386/pc_q35.c     |  19 +++++
>  include/hw/boards.h  | 207 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/hw/i386/pc.h | 224 
> ---------------------------------------------------
>  4 files changed, 251 insertions(+), 230 deletions(-)
> 
> -- 
> 1.9.3



reply via email to

[Prev in Thread] Current Thread [Next in Thread]