Re: [Qemu-devel] [PULL 2/8] vscclient: use glib thread primitives not qemu

[Paolo Bonzini]

Il 17/06/2014 21:11, Ed Maste ha scritto:
> On 17 June 2014 13:15, Paolo Bonzini <address@hidden> wrote:
> > Il 17/06/2014 19:10, Ed Maste ha scritto:
> >
> > > This change breaks the build on FreeBSD:
> > >
> > > libcacard/vscclient.c: In function 'send_msg':
> > > libcacard/vscclient.c:111: warning: implicit declaration of function
> > > 'htonl'
> > > ...
> >
> > Can you prepare a patch yourself?  I would be guessing the right header to
> > include, sorry.
>
> I can get it to build by either restoring the #include of
> qemu/sockets.h, or explicitly #including sys/socket.h and
> netinet/in.h.

The latter is better, this patch meant to remove most (though not yet 
all) dependencies of libcacard on include/qemu/.

  I'm happy to send a signed-off patch for either change,
> but it seems there must be more to the original change that I'm
> missing.  What provides the declarations for socket(), htonl(),
> AF_INET etc. in the Linux build?

netdb.h includes netinet/in.h, and netinet/in.h includes sys/socket.h. 
glibc is not particularly good at avoiding #includes within headers. :(

Paolo