Re: [Qemu-devel] [PATCH V6 00/29] add direct support of event in qapi schema

[Paolo Bonzini]

Il 18/06/2014 06:00, Eric Blake ha scritto:
> > > -typedef void (*QMPEventFuncEmit)(int event_kind, QDict *dict, Error **errp);
> > > +typedef void (*QMPEventFuncEmit)(unsigned event, QDict *dict, Error **errp);
> It looks like you have some churn on this definition; patch 4/29 in your
> qapi-event branch did:
>
> -enum QAPIEvent;
> -typedef void (*QMPEventFuncEmit)(enum QAPIEvent event, QDict *dict,
> Error **errp);
> +typedef void (*QMPEventFuncEmit)(unsigned event, QDict *dict, Error
> **errp);
>
> Can you hoist the use of 'unsigned' directly into 2/29 to minimize the
> churn?

Yes, will fix in a couple of hours.

Paolo