[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set already use
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set already used memdev |
Date: |
Tue, 17 Jun 2014 12:53:36 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 |
On 06/17/2014 12:45 PM, Peter Maydell wrote:
> On 17 June 2014 19:39, Eric Blake <address@hidden> wrote:
>> On 06/17/2014 11:36 AM, Michael S. Tsirkin wrote:
>>> From: Igor Mammedov <address@hidden>
>>>
>>> using the same memdev backend more than once will cause
>>> assersion at MemoryRegion mapping time becase it's already
>>
>> s/assersion/assertion/; s/becase/because/
>> (but probably too late now that this is a pull request)
>
> Incidentally, if anybody notices something that should
> mean a pull request ought not to be applied, they need
> to send an email which is a followup to the cover letter.
> Otherwise there's no guarantee I'll notice it when I'm
> processing the pullreq.
Got it. So far, all that I've pointed out can be done as followups
(typos in code) or ignored as too late (typos in commit message) - I
haven't found anything that should prevent this pull request from
actually going in.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PULL 004/103] vl.c: daemonize before guest memory allocation, (continued)
- [Qemu-devel] [PULL 004/103] vl.c: daemonize before guest memory allocation, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 005/103] add memdev backend infrastructure, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 006/103] vl.c: extend -m option to support options for memory hotplug, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 007/103] qdev: hotplug for buss-less devices, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 002/103] pc: ACPI BIOS: use enum for defining memory affinity flags, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 008/103] qdev: expose DeviceState.hotplugged field as a property, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 011/103] pc-dimm: do not allow to set already used memdev, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 010/103] memory: add memory_region_is_mapped() API, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 009/103] pc: implement pc-dimm device abstraction, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 014/103] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 015/103] pc: exit QEMU if compat machine doesn't support memory hotlpug, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 013/103] pc: exit QEMU if number of slots more than supported 256, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 017/103] pc-dimm: add busy address check and address auto-allocation, Michael S. Tsirkin, 2014/06/17
- [Qemu-devel] [PULL 018/103] pc-dimm: add busy slot check and slot auto-allocation, Michael S. Tsirkin, 2014/06/17