Re: [Qemu-devel] [PULL 00/18] linux-user fixes

[Peter Maydell]

On 9 June 2014 13:46,  <address@hidden> wrote:
> From: Riku Voipio <address@hidden>
>
> Mostly fixes, but a bigger rework in signal.c to allow compiling with gcc-4.9
>
> The following changes since commit 959e41473f2179850578482052fb73b913bc4e42:
>
>   slirp/arp: do not special-case bogus IP addresses (2014-06-09 01:49:28 
> +0200)
>
> are available in the git repository at:
>
>   git://git.linaro.org/people/riku.voipio/qemu.git linux-user-for-upstream
>
> for you to fetch changes up to b4032ebd7dbfdc38430878c557c9c83c9f4ec2d0:
>
>   User mode support for Linux ELF files with no section header (2014-06-09 
> 15:19:59 +0300)

Hi; I'm afraid this fails to build for me when building
m68k-linux-user:

/root/qemu/linux-user/signal.c: In function 'target_rt_restore_ucontext':
/root/qemu/linux-user/signal.c:5079:5: error: 'err' may be used
uninitialized in this function [-Werror=uninitialized]

because the function never sets 'err' but then
returns it.

(32-bit, ARM, gcc 4.7.2. I don't know why the other
compilers don't spot this; perhaps they inline the
function and then figure out that the unused return
value isn't actually ever used.)

thanks
-- PMM