[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 0/3] Quorum maintainance operations
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v6 0/3] Quorum maintainance operations |
Date: |
Mon, 9 Jun 2014 15:19:02 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 06, 2014 at 05:20:25PM +0200, Benoît Canet wrote:
> in V6:
> rebased on latest Stefanha's block branch
>
> Benoît Canet (3):
> quorum: Add the rewrite-corrupted parameter to quorum.
> block: Add drive-mirror-replace command
> qemu-iotests: Add 096 new test for drive-mirror-replace.
>
> block.c | 8 +-
> block/mirror.c | 118 +++++++++++++++++++++-
> block/quorum.c | 97 ++++++++++++++++--
> blockdev.c | 27 +++++
> include/block/block.h | 3 +
> include/block/block_int.h | 15 +++
> qapi/block-core.json | 38 +++++++-
> qmp-commands.hx | 5 +
> tests/qemu-iotests/041 | 34 +------
> tests/qemu-iotests/081 | 15 ++-
> tests/qemu-iotests/081.out | 10 ++
> tests/qemu-iotests/096 | 222
> ++++++++++++++++++++++++++++++++++++++++++
> tests/qemu-iotests/096.out | 5 +
> tests/qemu-iotests/group | 1 +
> tests/qemu-iotests/iotests.py | 33 +++++++
> trace-events | 1 +
> 16 files changed, 585 insertions(+), 47 deletions(-)
> create mode 100755 tests/qemu-iotests/096
> create mode 100644 tests/qemu-iotests/096.out
My comment on v5 still applies. There is no need for a new QAPI
command. The "replace" operation just requires an extra argument to the
drive-mirror command.
Stefan
pgpoQcL0EjDD1.pgp
Description: PGP signature