[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/9] virtio-blk: Convert VirtIOBlockReq.elem
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/9] virtio-blk: Convert VirtIOBlockReq.elem to pointer |
Date: |
Fri, 6 Jun 2014 15:06:47 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Fri, Jun 06, 2014 at 09:53:23AM +0800, Fam Zheng wrote:
> diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c
> index 49507ac..388741e 100644
> --- a/hw/block/virtio-blk.c
> +++ b/hw/block/virtio-blk.c
> @@ -27,6 +27,22 @@
> #endif
> #include "hw/virtio/virtio-bus.h"
>
> +static VirtIOBlockReq *virtio_blk_alloc_request(VirtIOBlock *s)
> +{
> + VirtIOBlockReq *req = g_malloc0(sizeof(*req));
The virtio-blk.c code used g_malloc() but since we're using
g_slice_new0() for the VirtQueueElement, we might as well use the slice
allocator here too.
- [Qemu-devel] [PATCH v3 0/9] virtio-blk: Converge VirtIOBlockRequest into VirtIOBlockReq, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 1/9] virtio-blk: Move VirtIOBlockReq to header, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 2/9] virtio-blk: Convert VirtIOBlockReq.elem to pointer, Fam Zheng, 2014/06/05
- Re: [Qemu-devel] [PATCH v3 2/9] virtio-blk: Convert VirtIOBlockReq.elem to pointer,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v3 3/9] virtio-blk: Drop bounce buffer from dataplane code, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 4/9] virtio-blk: Drop VirtIOBlockRequest.read, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 5/9] virtio-blk: Replace VirtIOBlockRequest with VirtIOBlockReq, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 6/9] virtio-blk: Use VirtIOBlockReq.in to drop VirtIOBlockReq.inhdr, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 7/9] virtio-blk: Convert VirtIOBlockReq.out to structrue, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 8/9] virtio-blk: Fill in VirtIOBlockReq.out in dataplane code, Fam Zheng, 2014/06/05
- [Qemu-devel] [PATCH v3 9/9] virtio-blk: Fix and clean up the in_sg and out_sg check, Fam Zheng, 2014/06/05