[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 6/8] machine: Make -machine opts properties of Ma
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PULL 6/8] machine: Make -machine opts properties of MachineState |
Date: |
Fri, 30 May 2014 15:23:44 -0300 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, May 28, 2014 at 07:29:01PM +0200, Andreas Färber wrote:
[...]
> +static void machine_initfn(Object *obj)
> +{
> + object_property_add_str(obj, "accel",
> + machine_get_accel, machine_set_accel, NULL);
> + object_property_add_bool(obj, "kernel_irqchip",
> + machine_get_kernel_irqchip,
> + machine_set_kernel_irqchip,
> + NULL);
> + object_property_add(obj, "kvm_shadow_mem", "int",
> + machine_get_kvm_shadow_mem,
> + machine_set_kvm_shadow_mem,
> + NULL, NULL, NULL);
> + object_property_add_str(obj, "kernel",
> + machine_get_kernel, machine_set_kernel, NULL);
> + object_property_add_str(obj, "initrd",
> + machine_get_initrd, machine_set_initrd, NULL);
> + object_property_add_str(obj, "append",
> + machine_get_append, machine_set_append, NULL);
> + object_property_add_str(obj, "dtb",
> + machine_get_dtb, machine_set_dtb, NULL);
> + object_property_add_str(obj, "dumpdtb",
> + machine_get_dumpdtb, machine_set_dumpdtb, NULL);
> + object_property_add(obj, "phandle_start", "int",
> + machine_get_phandle_start,
> + machine_set_phandle_start,
> + NULL, NULL, NULL);
> + object_property_add_str(obj, "dt_compatible",
> + machine_get_dt_compatible,
> + machine_set_dt_compatible,
> + NULL);
> + object_property_add_bool(obj, "dump-guest-core",
> + machine_get_dump_guest_core,
> + machine_set_dump_guest_core,
> + NULL);
> + object_property_add_bool(obj, "mem-merge",
> + machine_get_mem_merge, machine_set_mem_merge,
> NULL);
> + object_property_add_bool(obj, "usb", machine_get_usb, machine_set_usb,
> NULL);
> + object_property_add_str(obj, "firmware",
> + machine_get_firmware, machine_set_firmware,
> NULL);
> +}
The "kvm-type" option was left out.
I don't have a ppc machine where I can test it, but it looks like this
makes the kvm-type option unusable, as
qemu_opt_foreach(machine_opts, object_set_property, current_machine, 1)
will now fail.
--
Eduardo
- [Qemu-devel] [PULL 0/8] QOM devices patch queue 2014-05-28, Andreas Färber, 2014/05/28
- [Qemu-devel] [PULL 1/8] qom-test: Test qom-list on link<> properties, Andreas Färber, 2014/05/28
- [Qemu-devel] [PULL 3/8] vl.c: Do not set 'type' property in obj_set_property(), Andreas Färber, 2014/05/28
- [Qemu-devel] [PULL 7/8] qdev: Implement named GPIOs, Andreas Färber, 2014/05/28
- [Qemu-devel] [PULL 4/8] qapi: Avoid output visitor crashing if it encounters a NULL value, Andreas Färber, 2014/05/28
- [Qemu-devel] [PULL 8/8] ssi: Name the CS GPIO, Andreas Färber, 2014/05/28
- [Qemu-devel] [PULL 6/8] machine: Make -machine opts properties of MachineState, Andreas Färber, 2014/05/28
- Re: [Qemu-devel] [PULL 6/8] machine: Make -machine opts properties of MachineState,
Eduardo Habkost <=
- [Qemu-devel] [PULL 5/8] tests: Check empty QMP output visitor, Andreas Färber, 2014/05/28
- [Qemu-devel] [PULL 2/8] machine: Conversion of QEMUMachineInitArgs to MachineState, Andreas Färber, 2014/05/28
- Re: [Qemu-devel] [PULL 0/8] QOM devices patch queue 2014-05-28, Peter Maydell, 2014/05/28