Re: [Qemu-devel] [RFC 5/5] qmp: add ACPI_DEVICE_OST event handling

[Igor Mammedov]

On Fri, 30 May 2014 09:26:05 -0600
Eric Blake <address@hidden> wrote:

> On 05/28/2014 08:57 AM, Igor Mammedov wrote:
> > emmits event when ACPI OSPM evaluates _OST method
> 
> s/emmits/emits/
> 
> > of ACPI device.
> > 
> > Signed-off-by: Igor Mammedov <address@hidden>
> > ---
> >  docs/qmp/qmp-events.txt   |   10 ++++++++++
> >  hw/acpi/memory_hotplug.c  |   29 ++++++++++++++++++++++++++++-
> >  include/monitor/monitor.h |    1 +
> >  monitor.c                 |    1 +
> >  4 files changed, 40 insertions(+), 1 deletions(-)
> 
> Your series has a race with Wenchao's series to turn events into
> full-blown QAPI citizens:
> 
> https://lists.gnu.org/archive/html/qemu-devel/2014-05/msg00000.html
> 
> (either can go in first, but the second one will have to rebase)
It's still RFC, so no issues with rebasing

> 
> > 
> > diff --git a/docs/qmp/qmp-events.txt b/docs/qmp/qmp-events.txt
> > index 145402e..f22df3b 100644
> > --- a/docs/qmp/qmp-events.txt
> > +++ b/docs/qmp/qmp-events.txt
> > @@ -539,3 +539,13 @@ Example:
> >  
> >  Note: If action is "reset", "shutdown", or "pause" the WATCHDOG event is
> >  followed respectively by the RESET, SHUTDOWN, or STOP events.
> > +
> > +ACPI_DEVICE_OST
> 
> The rest of this file is listed in sorted order.  Which means your
> addition should go near the beginning, not at the end.
Ok

> 
> -- 
> Eric Blake   eblake redhat com    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
> 


-- 
Regards,
  Igor