Re: [Qemu-devel] [RFC 4/6] monitor: Split monitor in two parts: core and system.

[Eric Blake]

On 05/28/2014 08:57 AM, Benoît Canet wrote:
> Since we want to link the monitor.c code with qemu-nbd this patch extracts
> system related parts and put them in a separate C module.
> 
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  Makefile                         |    1 +
>  Makefile.objs                    |    3 +-
>  Makefile.target                  |    1 +
>  include/monitor/monitor-system.h |   93 ++
>  include/monitor/monitor.h        |   13 +
>  monitor-system.c                 | 2497 ++++++++++++++++++++++++++++++
>  monitor.c                        | 3157 
> ++++----------------------------------
>  qmp-stub.c                       |   13 +

This is another heavyweight patch; to ease review, it is again worth
considering breaking it into smaller pieces, so the code motion between
files is easier to verify independently from other changes such as
converting functions from static to exported.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature