[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/3] hmp: Allow options with parameters
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-devel] [PATCH 1/3] hmp: Allow options with parameters |
Date: |
Wed, 28 May 2014 14:34:57 +0100 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
* Eric Blake (address@hidden) wrote:
> On 05/28/2014 05:20 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert" <address@hidden>
> >
> > HMP currently allows optional string parameters, however where
> > there are multiple optional string parameters the order and
> > interdependence of them becomes complex.
> >
> > Allow optional parameters of the form:
> >
> > -x string
> >
> > Also, add a hint to hmp-commands.hx as to where to find the
> > explanations of the flags.
> >
> > Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> > ---
> > hmp-commands.hx | 2 ++
> > monitor.c | 19 +++++++++++++++++--
> > 2 files changed, 19 insertions(+), 2 deletions(-)
>
> I like it. It can be used to solve one of the questions I raised to Jeff
> about his proposed HMP command to change the backing file name not
> actually being tractable as he had proposed it.
>
>
> > +++ b/monitor.c
> > @@ -110,6 +110,7 @@
> > * 'b' boolean
> > * user mode accepts "on" or "off"
> > * '-' optional parameter (eg. '-f')
>
> I'd reword this line:
>
> * '-' optional boolean parameter, on if present (eg. '-f')
>
> > + * '+' optional parameter with value parameter
>
> so that this line makes more sense as-is.
OK, I'll reword for the next cut.
Dave
>
> Reviewed-by: Eric Blake <address@hidden>
>
> --
> Eric Blake eblake redhat com +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK