[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 06/14] qemu-io: Plug memory leak in open command
From: |
Markus Armbruster |
Subject: |
[Qemu-devel] [PATCH v2 06/14] qemu-io: Plug memory leak in open command |
Date: |
Wed, 28 May 2014 11:16:59 +0200 |
Introduced in commit b543c5c. Spotted by Coverity.
Signed-off-by: Markus Armbruster <address@hidden>
---
qemu-io.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/qemu-io.c b/qemu-io.c
index ef3fef6..f63e771 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -54,6 +54,7 @@ static int openfile(char *name, int flags, int growable,
QDict *opts)
if (qemuio_bs) {
fprintf(stderr, "file open already, try 'help close'\n");
+ QDECREF(opts);
return 1;
}
@@ -175,6 +176,7 @@ static int open_f(BlockDriverState *bs, int argc, char
**argv)
} else if (optind == argc) {
return openfile(NULL, flags, growable, opts);
} else {
+ QDECREF(opts);
return qemuio_command_usage(&open_cmd);
}
}
--
1.9.3
- [Qemu-devel] [PATCH v2 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), (continued)
- [Qemu-devel] [PATCH v2 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 04/14] block: Plug memory leak on brv_open_image() error path, Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR, Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 05/14] qemu-io: Support multiple -o in open command, Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 08/14] blockdev: Plug memory leak in blockdev_init(), Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 09/14] blockdev: Plug memory leak in drive_init(), Markus Armbruster, 2014/05/28
- [Qemu-devel] [PATCH v2 06/14] qemu-io: Plug memory leak in open command,
Markus Armbruster <=
- [Qemu-devel] [PATCH v2 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, Markus Armbruster, 2014/05/28
- Re: [Qemu-devel] [PATCH v2 00/14] block: Plug assorted memory leaks, Kevin Wolf, 2014/05/28