[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_di
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency() |
|
Date: |
Wed, 28 May 2014 11:06:16 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 26.05.2014 um 19:37 hat Markus Armbruster geschrieben:
> On error path. Introduced in commit a046433a. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
Heh, that fail: label you're jumping to is well hidden in some random
error check in the middle of the function. Pure awesomeness, this code.
(Your fix looks correct, but I just had to comment on this...)
Kevin
- Re: [Qemu-devel] [PATCH 02/14] block/vvfat: Plug memory leak in enable_write_target(), (continued)
- [Qemu-devel] [PATCH 04/14] block: Plug memory leak on brv_open_image() error path, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 03/14] qcow2: Plug memory leak on qcow2_invalidate_cache() error paths, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 11/14] block/vvfat: Plug memory leak in check_directory_consistency(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 06/14] qemu-io: Plug memory leak in open command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26