[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOp
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOptDesc |
Date: |
Tue, 27 May 2014 20:57:15 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/07/2014 03:58 AM, Chunyan Liu wrote:
> Add def_value_str (default value) to QemuOptDesc, to replace function of the
> default value in QEMUOptionParameter.
>
> Improve qemu_opts_get_* functions: if find opt, return opt->str; otherwise,
> if desc->def_value_str is set, return desc->def_value_str; otherwise, return
> input defval.
>
> Improve qemu_opts_print: if option is set, print opt->str; otherwise, if
> desc->def_value_str is set, print it.
>
> Signed-off-by: Dong Xu Wang <address@hidden>
> Signed-off-by: Chunyan Liu <address@hidden>
> ---
> Changes:
> * backward split than v26. (2/33, 3/33)
>
> include/qemu/option.h | 1 +
> util/qemu-option.c | 56
> ++++++++++++++++++++++++++++++++++++++++++++-------
> 2 files changed, 50 insertions(+), 7 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts, (continued)
- [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts, Chunyan Liu, 2014/05/07
- Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts, Chun Yan Liu, 2014/05/07
- Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts, Chun Yan Liu, 2014/05/14
- [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 01/33] QemuOpts: move find_desc_by_name ahead for later calling, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 05/33] QemuOpts: change opt->name|str from (const char *) to (char *), Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 06/33] QemuOpts: move qemu_opt_del ahead for later calling, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 08/33] QemuOpts: add qemu_opts_print_help to replace print_option_help, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 09/33] QemuOpts: add conversion between QEMUOptionParameter to QemuOpts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOptDesc, Chunyan Liu, 2014/05/07
- Re: [Qemu-devel] [PATCH v27 03/33] QemuOpts: add def_value_str to QemuOptDesc,
Eric Blake <=
- [Qemu-devel] [PATCH v27 04/33] qapi: output def_value_str when query command line options, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 02/33] QemuOpts: repurpose qemu_opts_print to replace print_option_parameters, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 11/33] QemuOpts: check NULL input for qemu_opts_del, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 13/33] vvfat.c: handle cross_driver's create_options and create_opts, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 10/33] QemuOpts: add qemu_opts_append to replace append_option_parameters, Chunyan Liu, 2014/05/07
- [Qemu-devel] [PATCH v27 16/33] iscsi.c: replace QEMUOptionParameter with QemuOpts, Chunyan Liu, 2014/05/07