[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] ohw: correctly program BAR ad
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] ohw: correctly program BAR addresses of PCI devices |
|
Date: |
Wed, 28 May 2014 01:28:49 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 28.05.2014 01:22, schrieb Alexander Graf:
>
> On 23.04.14 23:19, Hervé Poussineau wrote:
>> Note that offsets are PReP ones, so this breaks compatibility with
>> hardware which has different values.
>
> So that means that this patch breaks non-PReP? I don't think we want
> that ;).
Please note that these patches are for OHW, and -M prep is the only
machine to still use OHW these days, with the QEMU counterparts touching
only PReP AFAICS, so I see no reason not to fix OHW - would you rather
guard that with some #ifdef to make it clearer?
I'm not sure about the correctness of these patches, so I'm dependent on
review and - more likely - need to finally carve some time for simply
testing whether they break anything and, if not, apply them.
Andreas