[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 08/26] tcg-ppc64: Fix TCG_TARGET_CALL_STACK_OFFSE
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v2 08/26] tcg-ppc64: Fix TCG_TARGET_CALL_STACK_OFFSET |
Date: |
Tue, 27 May 2014 14:26:17 -0700 |
The calling convention reserves space for the 8 register parameters on
the stack, so using only 6*8=48 as the offset was wrong. We never saw
this bug because we don't have any helpers with more than 5 parameters.
Signed-off-by: Richard Henderson <address@hidden>
---
tcg/ppc64/tcg-target.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c
index c5362da..44abf7b 100644
--- a/tcg/ppc64/tcg-target.c
+++ b/tcg/ppc64/tcg-target.c
@@ -1408,7 +1408,7 @@ static void tcg_out_qemu_st(TCGContext *s, TCGReg
data_reg, TCGReg addr_reg,
/* Parameters for function call generation, used in tcg.c. */
#define TCG_TARGET_STACK_ALIGN 16
-#define TCG_TARGET_CALL_STACK_OFFSET 48
+#define TCG_TARGET_CALL_STACK_OFFSET ((6 + 8) * SZR)
#define TCG_TARGET_EXTEND_ARGS 1
#define FRAME_SIZE ((int) \
--
1.9.3
- [Qemu-devel] [PATCH v2 00/26] Merge ppc32/ppc64 tcg backends, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 03/26] tcg-ppc64: Move functions around, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 02/26] tcg-ppc64: Avoid some hard-codings of TCG_TYPE_I64, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 04/26] tcg-ppc64: Relax register restrictions in tcg_out_mem_long, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 05/26] tcg-ppc64: Use tcg_out_{ld, st, cmp} internally, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 06/26] tcg-ppc64: Make TCG_AREG0 and TCG_REG_CALL_STACK enum constants, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 07/26] tcg-ppc64: Move call macros out of tcg-target.h, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 09/26] tcg-ppc64: Better parameterize the stack frame, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 01/26] tcg-ppc: Use uintptr_t in ppc_tb_set_jmp_target, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 08/26] tcg-ppc64: Fix TCG_TARGET_CALL_STACK_OFFSET,
Richard Henderson <=
- [Qemu-devel] [PATCH v2 10/26] tcg-ppc64: Use the correct test in tcg_out_call, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 11/26] tcg-ppc64: Support the ppc64 elfv2 ABI, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 12/26] tcg-ppc64: Adjust tcg_out_call for ELFv2, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 13/26] tcg-ppc64: Merge 32-bit ABIs into the prologue / frame code, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 14/26] tcg-ppc64: Fix sub2 implementation, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 15/26] tcg-ppc64: Begin merging ppc32 with ppc64, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 16/26] tcg-ppc64: Merge ppc32 brcond2, setcond2, muluh, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 17/26] tcg-ppc64: Merge ppc32 qemu_ld/st, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 18/26] tcg-ppc64: Merge ppc32 register usage, Richard Henderson, 2014/05/27
- [Qemu-devel] [PATCH v2 19/26] tcg-ppc64: Support mulsh_i32, Richard Henderson, 2014/05/27