Re: [Qemu-devel] [PATCH RFC 1/8] virtio: add subsections to the migration stream

[Paolo Bonzini]

Il 15/05/2014 14:58, Michael S. Tsirkin ha scritto:
> You are asking for examples of ugly assymetry?
> It's easy: grep for .load_state_old.
> You have here a bunch of functions loading format that qemu
> can no longer produce, with any set of flags.
> The only way to make them run is to install two qemu versions side by side,
> save from old one and load in the new one.
> What, would you guess, is the chance that they actually work?
>
> I'm going to send a patch removing all this stuff, it's
> effectively dead code, but this is just one, biggest example.

The RTC one definitely works.  I'd definitely support killing 
load_state_old functions that were introduced together with the vmstate 
conversion, though (around 0.10-0.11 I think).

Paolo