[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 12/34] dimm: do not allow to set already used mem
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH v3 12/34] dimm: do not allow to set already used memdev |
Date: |
Tue, 27 May 2014 15:01:09 +0200 |
using the same memdev backend more than once will cause
assersion at MemoryRegion mapping time becase it's already
mapped. Prevent it by checking that associated MemoryRegion
is not mapped.
Signed-off-by: Igor Mammedov <address@hidden>
---
hw/mem/dimm.c | 17 ++++++++++++++++-
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/hw/mem/dimm.c b/hw/mem/dimm.c
index bb81679..713ded5 100644
--- a/hw/mem/dimm.c
+++ b/hw/mem/dimm.c
@@ -42,6 +42,21 @@ static void dimm_get_size(Object *obj, Visitor *v, void
*opaque,
visit_type_int(v, &value, name, errp);
}
+static void dimm_check_memdev_is_busy(Object *obj, const char *name,
+ Object *val, Error **errp)
+{
+ MemoryRegion *mr;
+
+ mr = host_memory_backend_get_memory(MEMORY_BACKEND(val), errp);
+ if (memory_region_is_mapped(mr)) {
+ char *path = object_get_canonical_path_component(val);
+ error_setg(errp, "can't use already busy memdev: %s", path);
+ g_free(path);
+ } else {
+ qdev_prop_allow_set_link_before_realize(obj, name, val, errp);
+ }
+}
+
static void dimm_initfn(Object *obj)
{
DimmDevice *dimm = DIMM(obj);
@@ -50,7 +65,7 @@ static void dimm_initfn(Object *obj)
NULL, NULL, NULL, &error_abort);
object_property_add_link(obj, DIMM_MEMDEV_PROP, TYPE_MEMORY_BACKEND,
(Object **)&dimm->hostmem,
- qdev_prop_allow_set_link_before_realize,
+ dimm_check_memdev_is_busy,
OBJ_PROP_LINK_UNREF_ON_RELEASE,
&error_abort);
}
--
1.7.1
- [Qemu-devel] [PATCH v3 23/34] trace: pc: add DIMM slot & address allocation, (continued)
- [Qemu-devel] [PATCH v3 23/34] trace: pc: add DIMM slot & address allocation, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 24/34] acpi:piix4: allow plug/unlug callbacks handle not only PCI devices, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 25/34] acpi:piix4: add memory hotplug handling, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 28/34] pc: migrate piix4 & ich9 MemHotplugState, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 30/34] pc: propagate memory hotplug event to ACPI device, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 31/34] pc: ACPI BIOS: implement memory hotplug interface, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 32/34] pc: add "hotplug-memory-region-size" property to PC_MACHINE, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 29/34] pc: add acpi-device link to PCMachineState, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 33/34] pc: ACPI BIOS: reserve SRAT entry for hotplug mem hole, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 16/34] pc: exit QEMU if compat machine doesn't support memory hotlpug, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 12/34] dimm: do not allow to set already used memdev,
Igor Mammedov <=
- [Qemu-devel] [PATCH v3 19/34] dimm: add busy slot check and slot auto-allocation, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 20/34] acpi: rename cpu_hotplug_defs.h to pc-hotplug.h, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 27/34] acpi:ich9: add memory hotplug handling, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 26/34] pc: ich9 lpc: make it work with global/compat properties, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 15/34] pc: add 'etc/reserved-memory-end' fw_cfg interface for SeaBIOS, Igor Mammedov, 2014/05/27
- [Qemu-devel] [PATCH v3 34/34] pc: ACPI BIOS: make GPE.3 handle memory hotplug event on PIIX and Q35 machines, Igor Mammedov, 2014/05/27
- Re: [Qemu-devel] [PATCH v3 00/34] pc: ACPI memory hotplug, Peter Crosthwaite, 2014/05/29