[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-stable] [PATCH 01/14] qemu-img: Plug memory leak
From: |
Benoît Canet |
Subject: |
Re: [Qemu-devel] [Qemu-stable] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path |
Date: |
Tue, 27 May 2014 12:10:21 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
The Monday 26 May 2014 à 19:37:02 (+0200), Markus Armbruster wrote :
> Introduced in commit a283cb6; mostly harmless. Spotted by Coverity.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
> qemu-img.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 1ad899e..62ea27e 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -287,6 +287,7 @@ static int print_block_option_help(const char *filename,
> const char *fmt)
> proto_drv = bdrv_find_protocol(filename, true);
> if (!proto_drv) {
> error_report("Unknown protocol '%s'", filename);
> + free_option_parameters(create_options);
> return 1;
> }
> create_options = append_option_parameters(create_options,
> --
> 1.9.3
>
>
Reviewed-by: Benoit Canet <address@hidden>
- Re: [Qemu-devel] [PATCH 13/14] block/sheepdog: Plug memory leak in sd_snapshot_create(), (continued)
- [Qemu-devel] [PATCH 12/14] block/vvfat: Plug memory leak in read_directory(), Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 14/14] qemu-img: Plug memory leak in convert command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 10/14] block/qapi: Plug memory leak in dump_qobject() case QTYPE_QERROR, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [Qemu-stable] [PATCH 01/14] qemu-img: Plug memory leak on block option help error path,
Benoît Canet <=
- [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Markus Armbruster, 2014/05/26
- Re: [Qemu-devel] [PATCH 07/14] qemu-io: Don't print NULL when open without non-option arg fails, Kevin Wolf, 2014/05/28
- [Qemu-devel] [PATCH 05/14] qemu-io: Support multiple -o in open command, Markus Armbruster, 2014/05/26
- [Qemu-devel] [PATCH 09/14] blockdev: Plug memory leak in drive_init(), Markus Armbruster, 2014/05/26