[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device argument c
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH 4/7] monitor: Add host_net_add device argument completion. |
Date: |
Mon, 26 May 2014 11:20:24 +0200 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Sun, May 25, 2014 at 05:12:55PM +0100, Hani Benhabiles wrote:
> On Fri, May 23, 2014 at 02:05:03PM +0200, Stefan Hajnoczi wrote:
> > On Tue, May 20, 2014 at 12:03:17AM +0100, Hani Benhabiles wrote:
> > > diff --git a/hmp-commands.hx b/hmp-commands.hx
> > > index 919af6e..6aaec1b 100644
> > > --- a/hmp-commands.hx
> > > +++ b/hmp-commands.hx
> > > @@ -1209,9 +1209,10 @@ ETEXI
> > > {
> > > .name = "host_net_add",
> > > .args_type = "device:s,opts:s?",
> > > - .params = "tap|user|socket|vde|netmap|dump [options]",
> > > + .params = "tap|user|socket|vde|bridge|dump [options]",
> >
> > Why did you delete "netmap"? I guess "bridge" should have been appended.
> >
>
> Because "netmap" fails the net_host_check_device() check:
>
> (qemu) host_net_add user
> (qemu) host_net_add foooo
> invalid host network device foooo
> (qemu) host_net_add netmap
> invalid host network device netmap
>
> Should "netmap" be added there ?
Probably because your QEMU was not built with (optional) netmap support.
It's primarily used on FreeBSD but there is Linux code as well:
https://code.google.com/p/netmap/
Stefan
- Re: [Qemu-devel] monitor: Command completion for various commands, (continued)
[Qemu-devel] [PATCH 5/7] readline: Make completion strings always unique., Hani Benhabiles, 2014/05/19
[Qemu-devel] [PATCH 6/7] monitor: Add host_net_remove arguments completion., Hani Benhabiles, 2014/05/19
[Qemu-devel] [PATCH 7/7] monitor: Add delvm and loadvm argument completion., Hani Benhabiles, 2014/05/19