[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 8/8] block: Drop redundant bdrv_refresh_limit
From: |
Jeff Cody |
Subject: |
Re: [Qemu-devel] [PATCH v2 8/8] block: Drop redundant bdrv_refresh_limits |
Date: |
Fri, 23 May 2014 10:36:20 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Fri, May 23, 2014 at 09:29:48PM +0800, Fam Zheng wrote:
> The above bdrv_set_backing_hd already does this.
>
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> block.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/block.c b/block.c
> index aa9b5ab..a517d72 100644
> --- a/block.c
> +++ b/block.c
> @@ -1182,9 +1182,6 @@ int bdrv_open_backing_file(BlockDriverState *bs, QDict
> *options, Error **errp)
> }
> bdrv_set_backing_hd(bs, backing_hd);
>
> - /* Recalculate the BlockLimits with the backing file */
> - bdrv_refresh_limits(bs);
> -
> free_exit:
> g_free(backing_filename);
> return ret;
> --
> 1.9.2
>
I think there is another redundant one in block/stream.c, in
close_unused_images(). But that doesn't affect this patch:
Reviewed-by: Jeff Cody <address@hidden>
- [Qemu-devel] [PATCH v2 0/8] block: Drop in_use with op blocker, Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 1/8] block: Add BlockOpType enum, Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 2/8] block: Introduce op_blockers to BlockDriverState, Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 3/8] block: Replace in_use with operation blocker, Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 4/8] block: Move op_blocker check from block_job_create to its caller, Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 5/8] block: Add bdrv_set_backing_hd(), Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 6/8] block: Use bdrv_set_backing_hd everywhere, Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 7/8] block: Add backing_blocker in BlockDriverState, Fam Zheng, 2014/05/23
- [Qemu-devel] [PATCH v2 8/8] block: Drop redundant bdrv_refresh_limits, Fam Zheng, 2014/05/23
- Re: [Qemu-devel] [PATCH v2 8/8] block: Drop redundant bdrv_refresh_limits,
Jeff Cody <=
- Re: [Qemu-devel] [PATCH v2 0/8] block: Drop in_use with op blocker, Stefan Hajnoczi, 2014/05/23