[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/7] iotests: Drop Python version from 065's
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [PATCH v3 6/7] iotests: Drop Python version from 065's Shebang |
Date: |
Fri, 23 May 2014 12:02:24 +0800 |
User-agent: |
Mutt/1.5.23 (2014-03-12) |
On Thu, 05/22 23:30, Max Reitz wrote:
> Test 065 specified python2 to be used in its Shebang; this might not
> work on systems without a python2 symlink and furthermore it is now
> counter-productive, as the check script compares the Shebang to
> "#!/usr/bin/env python" and only uses the Python interpreter selected by
> configure on an exact match.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> tests/qemu-iotests/065 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qemu-iotests/065 b/tests/qemu-iotests/065
> index ab5445f..e89b61d 100755
> --- a/tests/qemu-iotests/065
> +++ b/tests/qemu-iotests/065
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python
> #
> # Test for additional information emitted by qemu-img info on qcow2
> # images
> --
> 1.9.3
>
>
If you decide to keep this patch (see my comments in 5/7),
Reviewed-by: Fam Zheng <address@hidden>
- Re: [Qemu-devel] [PATCH v3 2/7] configure: Enable out-of-tree iotests, (continued)
- [Qemu-devel] [PATCH v3 4/7] iotests: Source common.env, Max Reitz, 2014/05/22
- [Qemu-devel] [PATCH v3 5/7] iotests: Use $PYTHON for Python scripts, Max Reitz, 2014/05/22
- [Qemu-devel] [PATCH v3 6/7] iotests: Drop Python version from 065's Shebang, Max Reitz, 2014/05/22
- Re: [Qemu-devel] [PATCH v3 6/7] iotests: Drop Python version from 065's Shebang,
Fam Zheng <=
- [Qemu-devel] [PATCH v3 7/7] iotests: Fix 083 for out-of-tree builds, Max Reitz, 2014/05/22
- Re: [Qemu-devel] [PATCH v3 0/7] iotests: Allow out-of-tree run, Max Reitz, 2014/05/22