[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants
|
From: |
Tom Musta |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/9] target-ppc: Rename MMCR0/1 contants |
|
Date: |
Wed, 21 May 2014 11:55:51 -0500 |
|
User-agent: |
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 5/21/2014 1:20 AM, Alexey Kardashevskiy wrote:
> MMCR0 and MMCR1 have different numbers for 32 and 64 bit POWERPC.
> We are going to support 64bit versions too so let's rename 32bit ones
> to avoid confusion.
>
> 604 uses same SPR number for MMCR0 so it is included in this patch too.
I'm not sure that it is a 32-bit vs. 64-bit thing as much as it is an
evolution of Performance Monitor from individual Book IVs into the
ISA. Saying differently, the SPR number for MMCR0 is now specified
in the ISA and is the same for 32 and 64 bit implementations
... and is also the same for embedded versus server implementations.
When the 604 came out, the performance monitor was not yet part of
the ISA.
Other than that ...
Reviewed-by: Tom Musta <address@hidden>