[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not supported by
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] scripts/qapi.py: Avoid syntax not supported by Python 2.4 |
Date: |
Wed, 21 May 2014 13:42:19 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
Am 20.05.2014 20:29, schrieb Luiz Capitulino:
> The Python "except Foo as x" syntax was only introduced in
> Python 2.6, but we aim to support Python 2.4 and later.
> Use the old-style "except Foo, x" syntax instead, thus
> fixing configure/compile on systems with older Python.
>
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Luiz Capitulino <address@hidden>
> ---
> scripts/qapi.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 0265b40..86e9608 100644
> --- a/scripts/qapi.py
> +++ b/scripts/qapi.py
> @@ -116,7 +116,7 @@ class QAPISchema:
> continue
> try:
> fobj = open(include_path, 'r')
> - except IOError as e:
> + except IOError, e:
> raise QAPIExprError(expr_info,
> '%s: %s' % (e.strerror, include))
> exprs_include = QAPISchema(fobj, include, self.include_hist,
I have the same change applied locally, so
Tested-by: Andreas Färber <address@hidden>
Thanks,
Andreas