Re: [Qemu-devel] [PATCH] e1000: allow command-line selection of card model

[Andreas Färber]

Am 21.05.2014 11:04, schrieb Michael S. Tsirkin:
> On Wed, May 21, 2014 at 10:40:54AM +0200, Andreas Färber wrote:
>> Hi,
>>
>> Am 20.05.2014 17:05, schrieb Gabriel L. Somlo:
>>> Allow selection of different card models from the qemu
>>> command line, to better accomodate a wider range of guests.
>>>
>>> Based-on-patch-by: Romain Dolbeau <address@hidden>
>>
>> If that patch carried a Signed-off-by line, you should retain it.
> 
> Actually I think that would be confusing. Romain didn't sign off
> on *this* patch, he signed off on a previous one.
> A signature by Gabriel indicates Developer's Certificate of Origin 1.1
> which has an option to incorporate other's work - it
> does not seem to require signatures by these others.

With the same argument you could drop anyone's Sob you get as a
maintainer. But the purpose of Sob is to track through whose hands a
patch went, not just who last touched it.
My point here was that Based-on-patch-by is very unusual.

The alternative would be to leave the original From: Romain Dolbeau, his
Sob, then a [gsomlo: Dropped this, added that] followed by Sob.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg