[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/7] dump: select header bitness based on ELF class,
From: |
Laszlo Ersek |
Subject: |
[Qemu-devel] [PATCH 5/7] dump: select header bitness based on ELF class, not ELF architecture |
Date: |
Tue, 20 May 2014 13:39:45 +0200 |
The specific ELF architecture (d_machine) carries Too Much Information
(TM) for deciding between create_header32() and create_header64(), use
"d_class" instead (ELFCLASS32 vs. ELFCLASS64).
This change adapts write_dump_header() to write_elf_loads(), dump_begin()
etc. that also rely on the ELF class of the target for bitness selection.
Considering the current targets that support dumping, cpu_get_dump_info()
works as follows:
- target-s390x/arch_dump.c: (EM_S390, ELFCLASS64) only
- target-ppc/arch_dump.c (EM_PPC64, ELFCLASS64) only
- target-i386/arch_dump.c: sets (EM_X86_64, ELFCLASS64) vs. (EM_386,
ELFCLASS32) keying off the same Long Mode Active flag.
Hence no observable change.
Approximately-suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Laszlo Ersek <address@hidden>
---
dump.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dump.c b/dump.c
index e0a606f..7e0982b 100644
--- a/dump.c
+++ b/dump.c
@@ -998,11 +998,11 @@ out:
return ret;
}
static int write_dump_header(DumpState *s)
{
- if (s->dump_info.d_machine == EM_386) {
+ if (s->dump_info.d_class == ELFCLASS32) {
return create_header32(s);
} else {
return create_header64(s);
}
}
--
1.8.3.1
- [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps), Laszlo Ersek, 2014/05/20
- [Qemu-devel] [PATCH 3/7] dump: eliminate DumpState.page_shift ("guest's page shift"), Laszlo Ersek, 2014/05/20
- [Qemu-devel] [PATCH 6/7] dump: hoist lzo_init() from get_len_buf_out() to dump_init(), Laszlo Ersek, 2014/05/20
- [Qemu-devel] [PATCH 7/7] dump: simplify get_len_buf_out(), Laszlo Ersek, 2014/05/20
- [Qemu-devel] [PATCH 5/7] dump: select header bitness based on ELF class, not ELF architecture,
Laszlo Ersek <=
- [Qemu-devel] [PATCH 4/7] dump: eliminate DumpState.page_size ("guest's page size"), Laszlo Ersek, 2014/05/20
- Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps), Paolo Bonzini, 2014/05/20
- Re: [Qemu-devel] [PATCH 0/7] cleanups for compressed dumps (kdumps), Luiz Capitulino, 2014/05/28