Re: [Qemu-devel] [PATCH v4 0/3] SMBIOS cleanup round

[Michael S. Tsirkin]

On Mon, May 19, 2014 at 10:09:52AM -0400, Gabriel L. Somlo wrote:
> Changelog:
> 
> new in v4:
>   - slightly improved commit blurbs
> 
> v3:
>   - endian-ness fix (1/3) now correctly handles cpuid version and features
>   - included documentation (qemu-options.hx) for type 0 uefi flag (2/3)
>   - fixed type 17 field sizes ("word" means 16 bits, not 32 :) :)
> 
> 
> v2:
>   - fix endian-ness for *all* larger-than-8bit fields (patch 1/2)
>   - resubmit type0 update (2/2) with appropriate endian-ness fix
>     for 64-bit field.
> 

Thanks!
One question: we don't seem to have unit-test for this
interface in qemu, do we?
I would like to see at least a basic test along the lines of
tests/acpi-test.c: run bios to load tables from QEMU,
then do some basic checks on the tables that bios loaded.

> Gabriel L. Somlo (3):
>   SMBIOS: Fix endian-ness when populating multi-byte fields
>   SMBIOS: Update Type 0 struct generator for machines >= 2.1
>   SMBIOS: Fix type 17 field sizes
> 
>  hw/i386/smbios.c         | 110 
> +++++++++++++++++++++++++----------------------
>  include/hw/i386/smbios.h |  10 ++---
>  qemu-options.hx          |   4 +-
>  3 files changed, 65 insertions(+), 59 deletions(-)
> 
> -- 
> 1.9.0