Re: [Qemu-devel] [PATCH] qemu-iotests: Honor ${CACHEMODE} in 091

[Kevin Wolf]

Am 19.05.2014 um 14:24 hat Fam Zheng geschrieben:
> We should allow testing this on tmpfs. Any cache setting in iotests
> should try to obey $CACHEMODE.
> 
> Signed-off-by: Fam Zheng <address@hidden>

Should we set _default_cache_mode=none then at least? We should probably
also refuse to run with unsafe.

Kevin

>  tests/qemu-iotests/091 | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091
> index 384b3ac..a7deea8 100755
> --- a/tests/qemu-iotests/091
> +++ b/tests/qemu-iotests/091
> @@ -59,13 +59,13 @@ echo === Starting QEMU VM1 ===
>  echo
>  
>  qemu_comm_method="monitor"
> -_launch_qemu -drive file="${TEST_IMG}",cache=none,id=disk
> +_launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},id=disk
>  h1=$QEMU_HANDLE
>  
>  echo
>  echo === Starting QEMU VM2 ===
>  echo
> -_launch_qemu -drive file="${TEST_IMG}",cache=none,id=disk \
> +_launch_qemu -drive file="${TEST_IMG}",cache=${CACHEMODE},id=disk \
>               -incoming "exec: cat '${MIG_FIFO}'"
>  h2=$QEMU_HANDLE
>  
> -- 
> 1.9.2
>