[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4] qapi: skip redundant includes
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4] qapi: skip redundant includes |
Date: |
Fri, 16 May 2014 06:02:18 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/16/2014 04:51 AM, Benoît Canet wrote:
> The purpose of this change is to help create a json file containing
> common definitions; each bit of generated C code must be emitted
> only one time.
>
> A second history global to all QAPISchema instances has been added
> to detect when a file is included more than one time and skip these
> includes.
> It does not act as a stack and the changes made to it by the
> __init__ function are propagated back to the caller so it's really
> a global state.
>
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> docs/qapi-code-gen.txt | 2 +-
Looks like the only addition.
> +++ b/docs/qapi-code-gen.txt
> @@ -48,7 +48,7 @@ The QAPI schema definitions can be modularized using the
> 'include' directive:
> { 'include': 'path/to/file.json'}
>
> The directive is evaluated recursively, and include paths are relative to the
> -file using the directive.
> +file using the directive. Multiple includes of the same file are safe.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature