Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value

[Andreas Färber]

Am 14.05.2014 19:29, schrieb Marcel Apfelbaum:
> On Wed, 2014-05-14 at 19:00 +0200, Andreas Färber wrote:
>> Am 13.05.2014 21:08, schrieb Eric Blake:
>>> On 05/13/2014 11:36 AM, Andreas Färber wrote:
>>>> Am 07.05.2014 16:42, schrieb Marcel Apfelbaum:
>>>>> A NULL value is not added to visitor's stack, but there is no
>>>>> check for that when the visitor tries to return that value,
>>>>> leading to Qemu crash.
>>>>>
>>>>> Reviewed-by: Eric Blake <address@hidden> Signed-off-by:
>>>>> Marcel Apfelbaum <address@hidden>
>>>>
>>>> Where does the Rb come from on this v1? Is it in any tree
>>>> already?
>>>>
>>>
>>> The (weak) R-b was here: 
>>> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02861.html
>>
>> Thanks.
>>>
>> So Luiz was okay with it too, but his last message seems to be
>> indicating this needs to be fixed somewhere else, too:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05228.html
>> https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00217.html
>>
>> Can/should that be addressed as a follow-up? Or is there a test case
>> that breaks?
> Simple and "popular" test case: the user does not use the -kernel-cmdline 
> parameter.

You had already mentioned a NULL -kernel. I was asking what test case
Luiz' qmp_output_last() would be about. :)

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg