Re: [Qemu-devel] [PATCH 2/4] qapi: output visitor crashes qemu if it encounters a NULL value

[Andreas Färber]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 13.05.2014 21:08, schrieb Eric Blake:
> On 05/13/2014 11:36 AM, Andreas Färber wrote:
>> Am 07.05.2014 16:42, schrieb Marcel Apfelbaum:
>>> A NULL value is not added to visitor's stack, but there is no
>>> check for that when the visitor tries to return that value,
>>> leading to Qemu crash.
>>> 
>>> Reviewed-by: Eric Blake <address@hidden> Signed-off-by:
>>> Marcel Apfelbaum <address@hidden>
>> 
>> Where does the Rb come from on this v1? Is it in any tree
>> already?
>> 
> 
> The (weak) R-b was here: 
> https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg02861.html

Thanks.
> 
So Luiz was okay with it too, but his last message seems to be
indicating this needs to be fixed somewhere else, too:

https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05228.html
https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg00217.html

Can/should that be addressed as a follow-up? Or is there a test case
that breaks?

Regards,
Andreas

- -- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJTc6EeAAoJEPou0S0+fgE/EZEP/0Demtm8RD/bDXkgSZYq8H7C
6FuPxjrkx2F/5Cot36VWeyGWB9A4GX3xH8+OJAsWdPyiq2ChOVXub/knlfedvBKP
et8Y2uub5FoLV3l8fPOy8CCO97erF4ZpZ28L1Br7jeUO+gR/b0/a0c2fj3V5SeMO
vgY6or46nBteVTyYtkAVx4Ne3VddNjiJJrgTASJkIFCFicG1VSQn6+YT89qmEx1i
JL8bbh5UNQ/hSFgQzl88mge9Udv3Zjp1zmbochhdazmoG6dHy7g0A7TuDkhIqnLX
p4uEzerjJo+24z6rX50CRj4zr6jnZtMdSWJF25+hvRGOz0UsHQ8D5OTZfs7qwBN3
Nkzqx/tMGENcNOnivJ3CGu7GhlBBEK3moK885dlZQ8p7w0+agNQDrR0CSMJlI4ck
8LgxcDNfGgnK948ZZNPTAlqOR7ZJV1dNE1fHulPVNS1xSdk2h48xOn8NNncRAwyq
bs+45pxwTjp+L5WLF7XLKsVF1hYy4wi5pBhT0w+xTymYoP5aHKRmIhogvJY1b6Wf
5isZQUHUeGiepZ26smYROrrQhO4Q2ZqHKjp3yUNfhHaP7bdZYh9ykPQQZra+9+K/
lXNmzFIj2L+kdl5R6/pn9h3nZDjrWxGd+IreVASseW0RuLZXDivOtBKZJ6ZBAqQd
Dx5lbtVnihJl9KRRxQw2
=+B1b
-----END PGP SIGNATURE-----