[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3] qapi: skip redundant includes |
|
Date: |
Wed, 14 May 2014 09:04:14 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/14/2014 08:07 AM, Benoît Canet wrote:
> The purpose of this change is to help create a json file containing
> common definitions; each bit of generated C code must be emitted
> only one time.
>
> A second history global to all QAPISchema instances has been added
> to detect when a file is included more than one time and skip these
> includes.
> It does not act as a stack and the changes made to it by the
> __init__ function are propagated back to the caller so it's really
> a global state.
>
> Signed-off-by: Benoit Canet <address@hidden>
> ---
> scripts/qapi.py | 14 +++++++++++---
> tests/Makefile | 3 ++-
> tests/qapi-schema/include-repetition-sub.json | 2 ++
> tests/qapi-schema/include-repetition.err | 0
> tests/qapi-schema/include-repetition.exit | 1 +
> tests/qapi-schema/include-repetition.json | 3 +++
> tests/qapi-schema/include-repetition.out | 3 +++
> 7 files changed, 22 insertions(+), 4 deletions(-)
> create mode 100644 tests/qapi-schema/include-repetition-sub.json
> create mode 100644 tests/qapi-schema/include-repetition.err
> create mode 100644 tests/qapi-schema/include-repetition.exit
> create mode 100644 tests/qapi-schema/include-repetition.json
> create mode 100644 tests/qapi-schema/include-repetition.out
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature