Re: [Qemu-devel] [PATCH v3] snapshot: fixed bdrv_get_full_backing_filename can not get correct full_backing_filename

[Fam Zheng]

On Wed, 05/14 14:40, Stefan Hajnoczi wrote:
> On Sun, May 11, 2014 at 12:35:57AM +0800, Jun Li wrote:
> > From: Jun Li <address@hidden>
> > 
> > This patch fixed the following bug:
> > https://bugzilla.redhat.com/show_bug.cgi?id=1084302 .
> > 
> > path_combine can not calculate the correct full path name for backing_file.
> > Such as:
> > create a snapshot chain:
> > sn2->sn1->$BASE_IMG
> > backing file is : /home/wookpecker/img.qcow2
> > sn1 : /home/woodpecker/tmp/sn1
> > sn2 : /home/woodpecker/tmp/sn2
> > when create sn2, path_combine can not got a correct path for $BASE_IMG.
> > 
> > In this patch, will check the backing_filename is a symlink or not firstly,
> > then return the full(absolute) path via realpath.
> > 
> > Signed-off-by: Jun Li <address@hidden>
> > ---
> >  block.c | 18 +++++++++++++++++-
> >  1 file changed, 17 insertions(+), 1 deletion(-)
> 
> Please fix your patch email submission process so it doesn't send the
> same patch multiple times.
> 
> You've done this several times in the past.  It makes patch review more
> difficult than it needs to be for reviewers.  If I have to compare
> several emails and figure out which patch is the right one before
> reviewing I'm inclined not to review at all.
> 

This is indeed very confusing. (I've showed Jun the configuration I have to
send patches.)

If you hit enter too quickly or forgot something, it's OK to try again, but
using distinct subjects is important and makes it easier for us to know what's
happening.

If, by mistake the subjects you send are the same, please reply yourself to the
list, saying "please ignore this one", so we know which to look at.

Fam