[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help fun
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH] Remove g_sequence_lookup from qemu-img help function |
Date: |
Tue, 13 May 2014 13:37:12 -0600 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/13/2014 12:34 PM, Mike Day wrote:
> g_sequence_lookup is not supported by glib < 2.28. The usage
> of g_sequence_lookup is not essential in this context (its a
s/its/it's/
> safeguard against duplicate values in the help message).
> Removing the call enables the build on all platforms and
> does not change the operation of the help function.
>
> Signed-off-by: Mike Day <address@hidden>
> ---
> qemu-img.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/qemu-img.c b/qemu-img.c
> index 04ce02a..bf5e74c 100644
> --- a/qemu-img.c
> +++ b/qemu-img.c
> @@ -70,11 +70,8 @@ static void add_format_to_seq(void *opaque, const char
> *fmt_name)
> {
> GSequence *seq = opaque;
>
> - if (!g_sequence_lookup(seq, (gpointer)fmt_name,
> - compare_data, NULL)) {
> g_sequence_insert_sorted(seq, (gpointer)fmt_name,
Indentation is now off. Please unindent the body now that you are
removing the surrounding if.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature