Re: [Qemu-devel] [PATCH] block/nfs: use per-object vars and make it modular

[Fam Zheng]

On Tue, 05/13 15:35, Peter Lieven wrote:
> On 13.05.2014 15:19, Fam Zheng wrote:
> >On Tue, 05/13 15:04, Peter Lieven wrote:
> >>On 11.05.2014 15:07, Michael Tokarev wrote:
> >>>nfs block module uses libnfs and uses pkg-config to determine
> >>>its build information.  Somehow it used only --libs, not --cflags,
> >>>and added those libs into global $LIBS, instead of using per-object
> >>>variable.
> >>the missing cflags stuff was due to a bug in the libnfs.pc file.
> >>
> >>https://github.com/sahlberg/libnfs/commit/d47c989d886e5398143d43d3b6d25fdf7210cb11
> >>
> >>as there where no special flags I dropped it. this was before we realized
> >>that we had to depend on a newer libnfs version anyway. thanks for spotting 
> >>this.
> >>
> >>>Use both --libs and --cflags, use them as per-object variable,
> >>>and finally make block/nfs.o to be modular.
> >>can you explain the modular stuff?
> >As what is possible with iscsi, gluster and curl now, with this change nfs.o 
> >is
> >possible to be built to a separate block-nfs.so, if configured as
> >--enable-modules, and loaded on program start.
> 
> Aah okay. This is something new and not something I did wrong when the patch 
> was submitted?

Absolutely.

Fam