[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] usb: fix up post load checks
From: |
Michael S. Tsirkin |
Subject: |
Re: [Qemu-devel] [PATCH] usb: fix up post load checks |
Date: |
Tue, 13 May 2014 11:32:14 +0300 |
On Tue, May 13, 2014 at 09:50:09AM +0200, Gerd Hoffmann wrote:
> Hi,
>
> > + (dev->setup_state == SETUP_STATE_DATA &&
>
> Fails to build, SETUP_STATE_DATA is not defined here.
>
> I think we can simply drop that check, index should never ever be larger
> than len, no matter what the state is.
>
> cheers,
> Gerd
I'm confused by usb_generic_async_ctrl_complete which can modify len
without touching index.
If index is stale it could get > len?
Could you hop on irc so we can discuss?
--
MST
Re: [Qemu-devel] [PATCH] usb: fix up post load checks, Michael S. Tsirkin, 2014/05/14