[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in heade
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in headers and C files |
Date: |
Mon, 12 May 2014 10:37:13 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.5.0 |
On 05/08/2014 09:09 AM, Paolo Bonzini wrote:
> This series is a prerequisite for improving the SMAP emulation in
> qemu-system-x86_64. SMAP is a Broadwell feature and testing it in the
> kernel is probably the #1 reason why people are using TCG x86 nowadays.
>
> In order to implement some of the SMAP checks correctly, I need to define
> a new set of ld/st functions, similar to ldl_data but with a different
> definition of cpu_mmu_index. This series lets me do that painlessly,
> by simplifying the set of macros expected by softmmu_header.h. This is
> done by patches 2 to 4.
>
> In addition, implementation of the MMU lookups are spread across all C
> files. There is no reason for this, it can be done in cputlb.c directly.
> This is done by patches 5 to 7.
>
> CPU load/store functions are also split around multiple headers: tcg/tcg.h,
> softmmu_header.h, cpu-all.h, exec-all.h. This series consolidates them
> all in a single header, cpu_ldst.h, in patches 8 to 11.
>
> The only reason why this is RFC is that it depends on TCG backends
> stopping their use of helper_ld*_mmu and using instead the new
> "return-address aware" helpers. With this conversion done, helper_ld*_mmu
> are not anymore TCG-related and it makes sense to move them to cpu_ldst.h.
> The only backends left to convert are S390, with patches on the list,
> and MIPS, which should also get done for 2.1.
Bravo.
Patches 2-11:
Reviewed-by: Richard Henderson <address@hidden>
I'll make sure I get that mips patch set posted this week; I failed to do that
before going on holiday last week.
r~
- [Qemu-devel] [RFC PATCH 05/11] softmmu: move ALIGNED_ONLY to cpu.h, (continued)
- [Qemu-devel] [RFC PATCH 05/11] softmmu: move ALIGNED_ONLY to cpu.h, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 04/11] softmmu: move definition of CPU_MMU_INDEX to inclusion site, drop ACCESS_TYPE, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 02/11] softmmu: start introducing SOFTMMU_CODE_ACCESS in softmmu_header.h, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 08/11] softmmu: make do_unaligned_access extern, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 03/11] softmmu: move MMUSUFFIX under SOFTMMU_CODE_ACCESS, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 07/11] softmmu: move softmmu_template.h out of include/, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 10/11] softmmu: introduce cpu_ldst.h, Paolo Bonzini, 2014/05/08
- [Qemu-devel] [RFC PATCH 06/11] softmmu: commonize helper definitions, Paolo Bonzini, 2014/05/08
- Re: [Qemu-devel] [RFC PATCH 00/11] Cleanup load/store functions in headers and C files,
Richard Henderson <=