[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] spice: return unspecified address according to
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH] spice: return unspecified address according to protocol |
Date: |
Mon, 12 May 2014 14:38:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) |
Amos Kong <address@hidden> writes:
> On Mon, May 12, 2014 at 11:34:18AM +0200, Gerd Hoffmann wrote:
>> Hi,
>>
>> > info->has_host = true;
>> > - info->host = g_strdup(addr ? addr : "*");
>> > + info->host = g_strdup(addr ? addr : (qemu_opt_get_bool(opts,
>> > + "ipv6", 0)
>> > + ? "::" : "0.0.0.0"));
>>
>> "ipv6" means "force ipv6". If the option is not present spice-server
>> might still listen on ipv6, and qemu can't easily figure whenever that
>> is the case or not.
>
> OK. And management will not use this returned address, so it's
> not a serious issue.
>
> Thanks. NAK this patch.
Thanks for trying, Amos. The "*" is ugly... but I have no better ideas,
either.