Re: [Qemu-devel] [PATCH 1/2] CAN bus simple SJA1000 PCI card emulation for QEMU

[Peter Crosthwaite]

Hi Pavel,

On Sat, May 10, 2014 at 4:14 AM, Pavel Pisa <address@hidden> wrote:
> The work is based on Jin Yang GSoC 2013 work funded
> by Google and mentored in frame of RTEMS project GSoC
> slot donated to QEMU.
>
> Update from QEMU-1.4 version and architecture cleanup
> by Pavel Pisa (Czech Technical University in Prague).
>
> The core SJA1000 support is independent of provided
> PCI board. The simple core CAN bus infrastructure
> is independent as well.
>
> Connection to the real host CAN bus network through
> SocketCAN network interface is available for Linux
> host system as well.
>
> Signed-off-by: Pavel Pisa <address@hidden>
> ---
>  default-configs/pci.mak |   2 +
>  hw/net/Makefile.objs    |   4 +
>  hw/net/can_core.c       | 350 +++++++++++++++++++
>  hw/net/can_pci.c        | 238 +++++++++++++
>  hw/net/can_sja1000.c    | 878 
> ++++++++++++++++++++++++++++++++++++++++++++++++
>  hw/net/can_sja1000.h    | 163 +++++++++
>  include/net/can_emu.h   | 123 +++++++
>  7 files changed, 1758 insertions(+)

That's a big patch. And it seems to add a new API/framework, then new
users of that API. Can you add your core as a single patch, then
incrementally bring your devices stuff as subsequent patches? My guess
is this should be about 3 patches - are there any circular deps,
requiring you to bring your three c files all at once or is there a
logical order you can add them for ease of review?

Regards,
Peter