[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 06/17] qemu-img: Convert by cluster size if target is
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PULL 06/17] qemu-img: Convert by cluster size if target is compressed |
Date: |
Fri, 9 May 2014 21:03:26 +0200 |
From: Fam Zheng <address@hidden>
If target block driver forces compression, qemu-img convert needs to
write by cluster size as well as "-c" option.
Particularly, this applies for converting to VMDK streamOptimized
format.
Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
include/block/block.h | 4 ++++
qemu-img.c | 1 +
2 files changed, 5 insertions(+)
diff --git a/include/block/block.h b/include/block/block.h
index 467fb2b..27d8598 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -34,6 +34,10 @@ typedef struct BlockDriverInfo {
* opened with BDRV_O_UNMAP flag for this to work.
*/
bool can_write_zeroes_with_unmap;
+ /*
+ * True if this block driver only supports compressed writes
+ */
+ bool needs_compressed_writes;
} BlockDriverInfo;
typedef struct BlockFragInfo {
diff --git a/qemu-img.c b/qemu-img.c
index 317bc6c..04ce02a 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -1502,6 +1502,7 @@ static int img_convert(int argc, char **argv)
goto out;
}
} else {
+ compress = compress || bdi.needs_compressed_writes;
cluster_sectors = bdi.cluster_size / BDRV_SECTOR_SIZE;
}
--
1.9.0
- [Qemu-devel] [PULL 00/17] Block patches, Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 04/17] block/nfs: Check for NULL server part, Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 06/17] qemu-img: Convert by cluster size if target is compressed,
Stefan Hajnoczi <=
- [Qemu-devel] [PULL 05/17] block/iscsi: bump year in copyright notice, Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 07/17] vmdk: Implement .bdrv_write_compressed, Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 08/17] vmdk: Implement .bdrv_get_info(), Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 09/17] qemu-iotests: Test converting to streamOptimized from small cluster size, Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 10/17] block: Fix open flags with BDRV_O_SNAPSHOT, Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 11/17] vl.c: remove init_clocks call from main, Stefan Hajnoczi, 2014/05/09
- [Qemu-devel] [PULL 12/17] gluster: Correctly propagate errors when volume isn't accessible, Stefan Hajnoczi, 2014/05/09