Re: [Qemu-devel] [PATCH 004/124] savevm: Remove all the unneded version_minimum_id_old (arm)

[Juan Quintela]

Peter Maydell <address@hidden> wrote:
> On 21 April 2014 17:18, Peter Maydell <address@hidden> wrote:
>> On 21 April 2014 15:39, Juan Quintela <address@hidden> wrote:
>>> After previous Peter patch, they are redundant.  This way we don't asign 
>>> them
>>> except when needed.  Once there, there were lots of case where the ".fields"
>>> indentation was wrong:
>>>
>>>      .fields = (VMStateField []) {
>>> and
>>>      .fields =      (VMStateField []) {
>>>
>>> Change all the combinations to:
>>>
>>>      .fields = (VMStateField[]){
>>>
>>> The biggest problem (appart of aesthetics) was that checkpatch complained
>>> when we copy&pasted the code from one place to another.
>>>
>>> Signed-off-by: Juan Quintela <address@hidden>
>>> ---
>>
>> Reviewed-by: Peter Maydell <address@hidden>
>>
>> I'll hold this to apply to target-arm.next when you've got the dependent
>> patch into master.
>
> The dependent patch is now in master so I'm going to include this
> in the target-arm queue (with the various typos Eric pointed out
> in the commit message fixed).

I have it on mine.  And the "rest" part was also reviewed-by.

I can include it on my next pull request, or do it yourself, whatever is
easier for you.

Later, Juan.