Re: [Qemu-devel] [PATCH] Update QEMU checkpatch.pl to current linux version

[Peter Maydell]

On 8 May 2014 14:59, Markus Armbruster <address@hidden> wrote:
> Don Slutz <address@hidden> writes:
>> I have used to following to see how a new version compares:
>>
>>
>> k=500;i=0;j=0;for sha in $(git log --no-merges --format=format:"%h"
>> -$k);do let i=$i+1; git show $sha >/tmp/a; clear;echo $i;head -20
>> /tmp/a; ./scripts/checkpatch.pl --root=. /tmp/a; err=$?; if [ $err !=
>> 0 ]; then let j=$j+1;read foo;fi; done;echo Check $i, Bad $j
>>
>> ...
>> total: 0 errors, 0 warnings, 79 lines checked
>>
>> /tmp/a has no obvious style problems and is ready for submission.
>> Check 500, Bad 52
>
> How does your new checkpatch compare to our current one?

Yes; we do sometimes let checkpatch-failing commits through,
so it would be more interesting to know:
 * how many commits passed old-checkpatch but fail the new one
 * how many commits failed with old-checkpatch but pass now
 * in both cases, how many of the failures are false positives?

(the last of those is tricky to answer without eyeballing
the errors, unfortunately)

thanks
-- PMM